Skip to content

gh-148814: Fix an issue in Emscripten README#148752

Merged
freakboy3742 merged 1 commit intopython:mainfrom
StanFromIreland:emscriptem
Apr 20, 2026
Merged

gh-148814: Fix an issue in Emscripten README#148752
freakboy3742 merged 1 commit intopython:mainfrom
StanFromIreland:emscriptem

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Apr 19, 2026 •
edited by bedevere-app bot
Loading

Looking at:

cpython/configure.ac

Lines 7796 to 7804 in 9e23652

# Check whether to disable test modules. Once set, setup.py will not build
# test extension modules and "make install" will not install test suites.
AC_MSG_CHECKING([for --disable-test-modules])
AC_ARG_ENABLE([test-modules],
[AS_HELP_STRING([--disable-test-modules], [don't build nor install test modules])], [
AS_VAR_IF([enable_test_modules], [yes], [TEST_MODULES=yes], [TEST_MODULES=no])
], [TEST_MODULES=yes])
AC_MSG_RESULT([$TEST_MODULES])
AC_SUBST([TEST_MODULES])

@StanFromIreland StanFromIreland added docs Documentation in the Doc dir skip issue labels Apr 19, 2026
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Apr 19, 2026
@freakboy3742 freakboy3742 changed the title Fix an issue in Emscripten README gh-148814: Fix an issue in Emscripten README Apr 20, 2026
@freakboy3742 freakboy3742 added needs backport to 3.14 bugs and security fixes and removed skip issue labels Apr 20, 2026
@bedevere-app bedevere-app bot mentioned this pull request Apr 20, 2026
Closed
freakboy3742
freakboy3742 approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I've added an issue so it can be backported to 3.14, since the same problem exists there.

@freakboy3742 freakboy3742 merged commit d206d42 into python:main Apr 20, 2026
48 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Apr 20, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 20, 2026

Thanks @StanFromIreland for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 20, 2026

GH-148815 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Apr 20, 2026
freakboy3742 pushed a commit that referenced this pull request Apr 20, 2026
@miss-islington @StanFromIreland
[3.14] gh-148814: Fix an issue in Emscripten README (GH-148752) (#148815
c235654 
)

Correct the description of the default state of test module compilation.
(cherry picked from commit d206d42)

Co-authored-by: Stan Ulbrych <stan@python.org>
@hoodmane
Copy link
Copy Markdown
Contributor

hoodmane commented Apr 21, 2026

Thanks @StanFromIreland and @freakboy3742 !

@StanFromIreland StanFromIreland deleted the emscriptem branch April 21, 2026 06:34
@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Apr 21, 2026

I've added an issue so it can be backported to 3.14

You may have missed my previous message, JFYI you don’t have to create issues to allow backporting, Miss Islington will not mind.

@freakboy3742
Copy link
Copy Markdown
Contributor

freakboy3742 commented Apr 21, 2026

I've added an issue so it can be backported to 3.14

You may have missed my previous message, JFYI you don’t have to create issues to allow backporting, Miss Islington will not mind.

I did miss that message - apologies. I was under the impression that while it wasn't required, backports should have tickets for tracking purposes, so it's easier to tell when a fix has been applied across multiple branches (at least, I remember being told off for that in my early days as a committer!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@hoodmane hoodmane Awaiting requested review from hoodmane

Assignees

No one assigned

Labels

docs Documentation in the Doc dir OS-emscripten skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @hoodmane @freakboy3742